[css-writing-modes-3] text-orientation-upright-directionality-001 test and reference file

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[css-writing-modes-3] text-orientation-upright-directionality-001 test and reference file

Gérard Talbot-3
Jonathan,

[test]
http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/text-orientation-upright-directionality-001.htm

[reference file]
http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/reference/text-orientation-upright-directionality-001-ref.htm


I just entered the test result for Firefox 50 and Chrome 53 for your
test. I suggest 2 improvements.

1-
Right now, only Firefox supports 'writing-mode: sideways-lr' and
'writing-mode: sideways-rl'. If the reference file also uses <div
style="writing-mode:sideways-rl"> and <div
style="writing-mode:sideways-lr"> (which is the tested feature of the
test), then browsers which do not support sideways-* writing-modes will
"pass" (false positive) your test. (This is the case with Chrome 53 and
with Edge 13 too.) In order to work around this, I suggest to create an
image of the expected results and use a textual description for the
pass/fail conditions: we have done this in about 16 tests.

Eg
http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/text-orientation-010.htm

Sometimes, we also indicate that inter-character spacing can vary.

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/text-orientation-upright-vrl-002.htm


2-
I would split your test in 2 distinct, separate tests..

I can do this for you if you want...

Addendum
--------

I just noticed that we already had 2 tests doing what your test was
aiming at checking:

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/text-orientation-upright-slr-017.htm

http://test.csswg.org/suites/css-writing-modes-3_dev/nightly-unstable/html/text-orientation-upright-srl-018.htm

... although these 2 tests did not use Hebrew and Arabic characters like
you did with your text-orientation-upright-directionality-001 test.
Interestingly, Firefox 47 passes text-orientation-upright-slr-017 and
text-orientation-upright-srl-018 but fails your
text-orientation-upright-directionality-001 test. So, this is a good
addition.

Gérard
--
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html