Fwd: Re: [SCXML] Two more IRP XPath test syntax errors

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Fwd: Re: [SCXML] Two more IRP XPath test syntax errors

Ate Douma
Sorry, accidentally not replied to the list.

See below forward.

Regards, Ate


-------- Forwarded Message --------
Subject: Re: [SCXML] Two more IRP XPath test syntax errors
Date: Fri, 14 Nov 2014 22:26:30 +0100
From: Ate Douma <[hidden email]>
To: Jim Barnett <[hidden email]>

On 2014-11-14 21:36, Jim Barnett wrote:
> Fixed.  Thanks for finding these.  I'm sure that there are more.

Yep, just hit one more, but of a different nature:

test 330 fails on my implementation because the <scxml> in the document doesn't
have a version attribute specified.
Which the spec says is required, hence I'm enforcing it. But now the test fails :)

Thanks, Ate

>
> - Jim
>
> On 11/14/2014 3:12 PM, Ate Douma wrote:
>> Hi Jim,
>>
>> First of all thanks for fixing the test579 and test580!
>>
>> But as maybe expected, I'm hitting more XPath test failures caused by errors
>> in the IRP tests.
>>
>> In this case it concerns 2 errors in the confXpath.xsl stylesheet [1]
>> generating invalid test354 scxml for the xpath datamodel:
>>
>>   * <xsl:template match="//@conf:eventDataNamelistValue">
>>       <xsl:attribute name="expr">$_event/data/data[@id=Var'<xsl:value-of
>> select="."/>']/data/text()</xsl:attribute>
>>     </xsl:template>
>>
>>     the expression above has the first quote wrong, which should be at
>> @id='Var instead of @id=Var'
>>
>>   * <xsl:template match="//@conf:eventdataSomeVal">
>>       <xsl:attribute name="cond">_event.data = 123</xsl:attribute>
>>     </xsl:template>
>>
>>     this template produces _event.data which should be _event/data
>>
>> Can these trivial errors please be fixed?
>>
>> NB: after fixing these locally myself, test354 now passes successfully.
>>
>> Thanks,
>>
>> Ate
>>
>> [1] http://www.w3.org/Voice/2013/scxml-irp/confXPath.xsl
>>
>
>