Debian patches review

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Debian patches review

Regis Boudin
Hi,

So you know what's going on with the Debian packages, here is a quick
review of the patches I currently apply to the Amaya source code, which
are attached.

* cflags_cleanup.diff : removes the forcing of CFLAGS, so they can be set
when calling configure.
* rdf_conf_in_conf.diff : moves the call to redland configure from
Makefile.in to configure.in.
* raptor.diff : only use libraptor instead of librdf, as no symbol from
the redland library is actually used.
* enable_system_libwww.diff : add a "--enable-system-libww" flag, and
moves the call to the libwww configure to configure.in.

I know you don't plan to merge the first one, it is only here for reference.
As you reverted the second one, I guess you had issues with it. I would
appreciate any feedback so I can modify it to be in a good enough shape to
be included. Could you please try to build (like you would do for a
release) for MacOSX/Fedora, so we can try to have it merged cleanly ?
When rdf_conf_in_conf is successfully applied, adding raptor.diff should
be fairly trivial. The result is quite interesting, as, since the removal
of the bookmarks feature, redland is not used at all anymore.
the libwww patch is quite intrusive, so I won't try to push it. Still, if
anyone wants to try it, any feedback will be welcome.

As usual, any question is welcome, I will be more than happy to help.

Thanks,
Regis

cflags_cleanup.diff (1K) Download Attachment
rdf_conf_in_conf.diff (6K) Download Attachment
raptor.diff (8K) Download Attachment
enable_system_libwww.diff (17K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Debian patches review

Irene Vatton

On Monday 20 August 2007 14:22, Regis Boudin wrote:

> Hi,
>
> So you know what's going on with the Debian packages, here is a quick
> review of the patches I currently apply to the Amaya source code, which
> are attached.
>
> * cflags_cleanup.diff : removes the forcing of CFLAGS, so they can be set
> when calling configure.
> * rdf_conf_in_conf.diff : moves the call to redland configure from
> Makefile.in to configure.in.
> * raptor.diff : only use libraptor instead of librdf, as no symbol from
> the redland library is actually used.
> * enable_system_libwww.diff : add a "--enable-system-libww" flag, and
> moves the call to the libwww configure to configure.in.
>
> I know you don't plan to merge the first one, it is only here for
> reference. As you reverted the second one, I guess you had issues with it.
> I would appreciate any feedback so I can modify it to be in a good enough
> shape to be included. Could you please try to build (like you would do for
> a release) for MacOSX/Fedora, so we can try to have it merged cleanly ?

I reverted the second and the third one because I was not able to generate a
rpm with these patches (raptor is not found).
Unfortunately I'm not able to explain more.

> When rdf_conf_in_conf is successfully applied, adding raptor.diff should be
> fairly trivial. The result is quite interesting, as, since the removal of
> the bookmarks feature, redland is not used at all anymore.

> the libwww patch is quite intrusive, so I won't try to push it. Still, if
> anyone wants to try it, any feedback will be welcome.
>
> As usual, any question is welcome, I will be more than happy to help.
>
> Thanks,
> Regis

--
     Irène.
-----
Irène Vatton                     INRIA Rhône-Alpes
INRIA                               ZIRST
e-mail: [hidden email]       655 avenue de l'Europe
Tel.: +33 4 76 61 53 61             Montbonnot
Fax:  +33 4 76 61 52 07             38334 Saint Ismier Cedex - France


Reply | Threaded
Open this post in threaded view
|

Re: Debian patches review

Regis Boudin

On Fri, August 24, 2007 12:06, Irene Vatton wrote:
>> * cflags_cleanup.diff : removes the forcing of CFLAGS, so they can be
>> set
>> when calling configure.
>> * rdf_conf_in_conf.diff : moves the call to redland configure from
>> Makefile.in to configure.in.
>> * raptor.diff : only use libraptor instead of librdf, as no symbol from
>> the redland library is actually used.
>> * enable_system_libwww.diff : add a "--enable-system-libww" flag, and
>> moves the call to the libwww configure to configure.in.

> I reverted the second and the third one because I was not able to generate
> a
> rpm with these patches (raptor is not found).
> Unfortunately I'm not able to explain more.

Is there a chance to have the exact error message, or even better a full
build log ? It would really help to fix the issue, whatever it is.

Regis

Reply | Threaded
Open this post in threaded view
|

Re: Debian patches review

Irene Vatton

On Friday 31 August 2007 16:10, Regis Boudin wrote:

> On Fri, August 24, 2007 12:06, Irene Vatton wrote:
> >> * cflags_cleanup.diff : removes the forcing of CFLAGS, so they can be
> >> set
> >> when calling configure.
> >> * rdf_conf_in_conf.diff : moves the call to redland configure from
> >> Makefile.in to configure.in.
> >> * raptor.diff : only use libraptor instead of librdf, as no symbol from
> >> the redland library is actually used.
> >> * enable_system_libwww.diff : add a "--enable-system-libww" flag, and
> >> moves the call to the libwww configure to configure.in.
> >
> > I reverted the second and the third one because I was not able to
> > generate a
> > rpm with these patches (raptor is not found).
> > Unfortunately I'm not able to explain more.
>
> Is there a chance to have the exact error message, or even better a full
> build log ? It would really help to fix the issue, whatever it is.
>
> Regis

I suspect a problem with configure options used by amaya_wx.spec:
../configure --prefix=/usr/share --exec=/usr/share  --datadir=/usr/share

Regards
     Irène.
-----
Irène Vatton                     INRIA Rhône-Alpes
INRIA                               ZIRST
e-mail: [hidden email]       655 avenue de l'Europe
Tel.: +33 4 76 61 53 61             Montbonnot
Fax:  +33 4 76 61 52 07             38334 Saint Ismier Cedex - France


Reply | Threaded
Open this post in threaded view
|

Re: Debian patches review

Regis Boudin

Hi,

Sorry for the small delay, I was on holiday...

On Wed, September 5, 2007 07:58, Irene Vatton wrote:
>> Is there a chance to have the exact error message, or even better a full
>> build log ? It would really help to fix the issue, whatever it is.
>>
>
> I suspect a problem with configure options used by amaya_wx.spec:
> ../configure --prefix=/usr/share --exec=/usr/share  --datadir=/usr/share

I sincerely doubt this is related, as the prefix, exec, and datadir
parameters are not passed through.

However, I would likte to point that installing everything in /usr/share
is wrong. This directory is meant to include only the architecture
independant files. If you install everything in it, you put binaries,
which are certainly arch-dependant. For the record, what I pass for the
debian package is "--prefix=/usr/lib --bindir=/usr/bin".

Also, having a quick look at the spec file, it would be cleaner to replace
"make install prefix=$RPM_BUILD_ROOT/usr/share"
with
"make install DESTDIR=$RPM_BUILD_ROOT"

At the end, this will have exactly the same result, with a better
separation between your spec file and the actual Amaya build/install
scripts.

HTH,

Regis